On Wed, Jun 10, 2020 at 08:41:13PM +1000, Herbert Xu wrote:
> Adding two thousand lines of code to the kernel when you only need
> a few lines is ridiculous. Worse those two thousand lines increase
> the attack surface to the kernel because they're exposed to user-
> space.
Why isn't *this* in your commit message?
> Adding a hidden Kconfig symbol for the sake of reducing the kernel
> attack surface would seem worthwhile.
And that.
> In fact this isn't even an issue right now because you are still using
> the custom function.
Actually, I'd prefer your version which doesn't depend on FW_LOADER at
all for the above reasons.
Please resubmit with amended commit message, adding the justification
for the change.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
