On Wed, Jun 10, 2020 at 03:46:50PM +0200, Borislav Petkov wrote: > On Wed, Jun 10, 2020 at 01:12:09PM +0000, Luis Chamberlain wrote: > > On Wed, Jun 10, 2020 at 10:16:09AM +0200, Borislav Petkov wrote: > > > > > > Also, I'm working on removing that homegrown get_builtin_firmware() and > > > use the one in the fw loader: > > > > > > https://lkml.kernel.org/r/20200408094526.gc24...@zn.tnic > > > > I would like to still encourage this, even with this patch in place, > > as I think it makes this a proper call, and reflects better how the > > firmware loader is used exactly. > > > > FWIW, firmware loader will be changed soon to not be modular, and just > > built-in or disabled. > > I don't mind doing the work but Herbert has a point - there's no need to > require a bunch of code for a trivial function. > > What I could do in addition is move that trivial function into a > fw-specific header and have it defined unconditionally so that the > microcode loader can use it without needing the fw loader.
Would just have to see this part. But sounds like a better place than today. > The testcases stuff then goes ontop. Sure! Luis
