On Wed, Jun 10, 2020 at 06:52:10PM +0300, Alexander Popov wrote: > On 09.06.2020 21:47, Kees Cook wrote: > > On Thu, Jun 04, 2020 at 04:49:55PM +0300, Alexander Popov wrote: > >> Add 'verbose' plugin parameter for stackleak gcc plugin. > >> It can be used for printing additional info about the kernel code > >> instrumentation. > >> > >> For using it add the following to scripts/Makefile.gcc-plugins: > >> gcc-plugin-cflags-$(CONFIG_GCC_PLUGIN_STACKLEAK) \ > >> += -fplugin-arg-stackleak_plugin-verbose > >> > >> Signed-off-by: Alexander Popov <alex.po...@linux.com> > > > > Acked-by: Kees Cook <keesc...@chromium.org> > > I see that I will change this patch after leaving alloca() support. > I'm going to add debug printing about functions that call alloca(). > I have to omit your 'acked-by' for the changed patch, right?
If it changes dramatically, drop my Ack, yes. But since it's going via my tree, my Ack is mostly just a quick email marker to say "yes, looks good". :) -- Kees Cook
