Re: [PATCH] drm/exynos: fix ref count leak in mic_pre_enable

[Inki Dae]

Hi,

20. 6. 14. 오후 3:23에 Navid Emamdoost 이(가) 쓴 글:
> in mic_pre_enable, pm_runtime_get_sync is called which
> increments the counter even in case of failure, leading to incorrect
> ref count. In case of failure, decrement the ref count before returning.
> 
> Signed-off-by: Navid Emamdoost <navid.emamdo...@gmail.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_mic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c 
> b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> index a86abc173605..69ff74c2ceb5 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> @@ -270,7 +270,7 @@ static void mic_pre_enable(struct drm_bridge *bridge)
>  
>       ret = pm_runtime_get_sync(mic->dev);
>       if (ret < 0)
> -             goto unlock;
> +             goto turn_off;

How about just calling pm_runtime_put_noidle()?

if (ret < 0) {
        pm_runtime_put_noidle(mic->dev);
        goto unlock;
}

Thanks,
Inki Dae

>  
>       mic_set_path(mic, 1);
>  
>