On Wed, Jun 24, 2020 at 09:34:08AM +0800, Baolin Wang wrote: > OK, I understaood your concern. Now we will select the RR arbitration as > default > in nvme_enable_ctrl(), but for some cases, we will not set the arbitration > burst > values from userspace, and we still want to use the defaut arbitration burst > that > recommended by the controller, taking into consideration any latency > requirements. > > So I'd like to add a parameter to decide if we can use the default arbitration > burst like below, how do yo think? Thanks.
I wouldn't call this the 'default' arbitration since it usually is not the default. This is the 'recommended' arbitration value. > static bool use_default_arb; > module_param(use_default_arb, bool, 0444); > MODULE_PARM_DESC(use_default_arb, "use default arbitration burst that > recommended by the controller"); "use controller's recommended arbitration burst"
