Hi Ricardo, I love your patch! Yet something to improve:
[auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on v5.8-rc2 next-20200624] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ricardo-Ribalda/i2c-designware-platdrv-Set-class-based-on-dmi/20200624-171557 base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next config: arc-allyesconfig (attached as .config) compiler: arc-elf-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> All error/warnings (new ones prefixed by >>): drivers/i2c/busses/i2c-designware-platdrv.c: In function 'dw_i2c_hwmon_bus': >> drivers/i2c/busses/i2c-designware-platdrv.c:196:13: error: implicit >> declaration of function 'dmi_get_system_info'; did you mean >> 'acpi_get_system_info'? [-Werror=implicit-function-declaration] 196 | if (strstr(dmi_get_system_info(DMI_PRODUCT_NAME), "QT5222")) | ^~~~~~~~~~~~~~~~~~~ | acpi_get_system_info >> drivers/i2c/busses/i2c-designware-platdrv.c:196:13: warning: passing >> argument 1 of 'strstr' makes pointer from integer without a cast >> [-Wint-conversion] 196 | if (strstr(dmi_get_system_info(DMI_PRODUCT_NAME), "QT5222")) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | int In file included from include/linux/bitmap.h:9, from include/linux/cpumask.h:12, from include/linux/rcupdate.h:31, from include/linux/radix-tree.h:15, from include/linux/idr.h:15, from include/linux/kernfs.h:13, from include/linux/sysfs.h:16, from include/linux/kobject.h:20, from include/linux/of.h:17, from include/linux/irqdomain.h:35, from include/linux/acpi.h:13, from drivers/i2c/busses/i2c-designware-platdrv.c:11: include/linux/string.h:82:15: note: expected 'const char *' but argument is of type 'int' 82 | extern char * strstr(const char *, const char *); | ^~~~~~ cc1: some warnings being treated as errors vim +196 drivers/i2c/busses/i2c-designware-platdrv.c 193 194 static bool dw_i2c_hwmon_bus(void) 195 { > 196 if (strstr(dmi_get_system_info(DMI_PRODUCT_NAME), "QT5222")) 197 return true; 198 return false; 199 } 200 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
