On Wed, Jun 24, 2020 at 10:43 AM Yang Shi <[email protected]> wrote: > > Since commit bbddabe2e436aa7869b3ac5248df5c14ddde0cbf ("mm: filemap: > only do access activations on reads"), mark_page_accessed() is called > for reads only. But the idle flag is cleared by mark_page_accessed() so > the idle flag won't get cleared if the page is write accessed only. > > Basically idle page tracking is used to estimate workingset size of > workload, noticeable size of workingset might be missed if the idle flag > is not maintained correctly. > > It seems good enough to just clear idle flag for write operations. > > Fixes: bbddabe2e436 ("mm: filemap: only do access activations on reads") > Cc: Johannes Weiner <[email protected]> > Cc: Rik van Riel <[email protected]> > Cc: Shakeel Butt <[email protected]> > Reported-by: Gang Deng <[email protected]> > Signed-off-by: Yang Shi <[email protected]>
Reviewed-by: Shakeel Butt <[email protected]>
