On Thu, Jun 25, 2020 at 9:10 PM Nathan Chancellor
<natechancel...@gmail.com> wrote:
>
> Clang warns:
>
> drivers/net/bonding/bond_main.c:4657:23: warning: equality comparison
> with extraneous parentheses [-Wparentheses-equality]
> if ((BOND_MODE(bond) == BOND_MODE_ACTIVEBACKUP))
> ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
>
> drivers/net/bonding/bond_main.c:4681:23: warning: equality comparison
> with extraneous parentheses [-Wparentheses-equality]
> if ((BOND_MODE(bond) == BOND_MODE_ACTIVEBACKUP))
> ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
>
> This warning occurs when a comparision has two sets of parentheses,
> which is usually the convention for doing an assignment within an
> if statement. Since equality comparisons do not need a second set of
> parentheses, remove them to fix the warning.
>
> Fixes: 18cb261afd7b ("bonding: support hardware encryption offload to slaves")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1066
> Signed-off-by: Nathan Chancellor <natechancel...@gmail.com>
Thanks for the patch. I recently saw this in a report from KernelCI
this morning. Adding a tag to reward the robot.
Reported-by: kernelci.org bot <b...@kernelci.org>
Reviewed-by: Nick Desaulniers <ndesaulni...@google.com>
> ---
> drivers/net/bonding/bond_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 4ef99efc37f6..b3479584cc16 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -4654,7 +4654,7 @@ void bond_setup(struct net_device *bond_dev)
>
> #ifdef CONFIG_XFRM_OFFLOAD
> /* set up xfrm device ops (only supported in active-backup right now)
> */
> - if ((BOND_MODE(bond) == BOND_MODE_ACTIVEBACKUP))
> + if (BOND_MODE(bond) == BOND_MODE_ACTIVEBACKUP)
> bond_dev->xfrmdev_ops = &bond_xfrmdev_ops;
> bond->xs = NULL;
> #endif /* CONFIG_XFRM_OFFLOAD */
> @@ -4678,7 +4678,7 @@ void bond_setup(struct net_device *bond_dev)
>
> bond_dev->hw_features |= NETIF_F_GSO_ENCAP_ALL | NETIF_F_GSO_UDP_L4;
> #ifdef CONFIG_XFRM_OFFLOAD
> - if ((BOND_MODE(bond) == BOND_MODE_ACTIVEBACKUP))
> + if (BOND_MODE(bond) == BOND_MODE_ACTIVEBACKUP)
> bond_dev->hw_features |= BOND_XFRM_FEATURES;
> #endif /* CONFIG_XFRM_OFFLOAD */
> bond_dev->features |= bond_dev->hw_features;
>
> base-commit: 7bed14551659875e1cd23a7c0266394a29a773b3
> --
--
Thanks,
~Nick Desaulniers
