On Sun, Jun 28, 2020 at 2:50 PM Jiri Olsa <jo...@redhat.com> wrote: > > On Fri, Jun 26, 2020 at 01:01:51PM -0700, Ian Rogers wrote: > > Firstly, thanks for this work! > > > > On Fri, Jun 26, 2020 at 12:47 PM Jiri Olsa <jo...@kernel.org> wrote: > > > > > > Renaming expr__add_id to expr__add_val so we can use > > > expr__add_id to actually add just id in following changes. > > > > Perhaps clear up in the commit message that add id won't add an id and > > a value, just the id. I don't mind long intention revealing function > > names, so expr__add_id_with_val may most fully convey this change. > > ok, how about expr__add_id_val ?
Sounds good to me, thanks! Ian > jirka >
