On Sun, Jun 28, 2020 at 2:25 PM Jiri Olsa <jo...@redhat.com> wrote: > > On Fri, Jun 26, 2020 at 01:04:41PM -0700, Ian Rogers wrote: > > On Fri, Jun 26, 2020 at 12:47 PM Jiri Olsa <jo...@kernel.org> wrote: > > > > > > Adding struct expr_parse_data to keep expr value > > > instead of just simple double pointer, so we can > > > store more data for ID in following changes. > > > > Nit, expr_parse_data sounds a bit like data that is created just at > > parse time. Perhaps id_data, for data associated with an id? > > we should keep the expr prefix, expr_id_data ?
Sounds good to me. Thanks, Ian > jirka >
