On Mon, Jun 29, 2020 at 10:49:31PM +0000, Krishna Reddy wrote: > >> + if (!nvidia_smmu->bases[0]) > >> + nvidia_smmu->bases[0] = smmu->base; > >> + > >> + return nvidia_smmu->bases[inst] + (page << smmu->pgshift); } > > >Not critical -- just a nit: why not put the bases[0] in init()? > > smmu->base is not available during nvidia_smmu_impl_init() call. It is set > afterwards in arm-smmu.c. > It can't be avoided without changing the devm_ioremap() and impl_init() call > order in arm-smmu.c.
I see...just checked arm_ssmu_impl_init().
