On Tue, 30 Jun 2020, Johan Hovold wrote: > Expand the control-bank accessors that were implemented using macros. > This allows the definitions of these exported functions to be found more > easily and specifically avoids a W=1 compiler warning due to the > redundant brightness sanity check: > > drivers/mfd/lm3533-ctrlbank.c: In function 'lm3533_ctrlbank_set_brightness': > drivers/mfd/lm3533-ctrlbank.c:98:10: warning: comparison is always false due > to limited range of data type [-Wtype-limits] > 98 | if (val > LM3533_##_NAME##_MAX) \ > | ^ > drivers/mfd/lm3533-ctrlbank.c:125:1: note: in expansion of macro > 'lm3533_ctrlbank_set' > 125 | lm3533_ctrlbank_set(brightness, BRIGHTNESS); > | ^~~~~~~~~~~~~~~~~~~ > > Signed-off-by: Johan Hovold <jo...@kernel.org> > --- > drivers/mfd/lm3533-ctrlbank.c | 94 +++++++++++++++++++++-------------- > 1 file changed, 56 insertions(+), 38 deletions(-)
That'll work. Thanks Johan. Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
