Hi Greg, Thanks a lot for looking at the patch.
(trimming text) On Wed, Jul 01, 2020 at 02:01:31PM +0200, Greg Kroah-Hartman wrote: > On Tue, Jun 30, 2020 at 05:31:48PM -0700, Prashant Malani wrote: > > Add a user-visible attribute for the number of alt modes available in a > > partner. This allows userspace to determine whether there are any > > remaining alt modes left to be registered by the kernel driver. It can > > begin implementing any policy state machine after all available alt > > modes have been registered with the connector class framework. > > > > This value is set to "-1" initially, which is an invalid value, > > signifying that a valid number of alt modes haven't been set for the > > partner. > > > > Signed-off-by: Prashant Malani <[email protected]> > > Cc: Benson Leung <[email protected]> > > + */ > > +int typec_partner_set_num_altmodes(struct typec_partner *partner, int > > num_altmodes) > > +{ > > + if (num_altmodes < 0) > > + return -EINVAL; > > + > > + partner->num_altmodes = num_altmodes; > > + sysfs_notify(&partner->dev.kobj, NULL, "num_altmodes"); > > + > > + return 0; > > +} > > +EXPORT_SYMBOL_GPL(typec_partner_set_num_altmodes); > > Who is calling this? We need a user before we can add a newly exported > function. cros-ec-typec (drivers/platform/chrome/cros_ec_typec.c), but the patch for that isn't ready yet. I will submit v2 when that patch is ready for review. My apologies for not considering this earlier. Best regards, > > thanks, > > greg k-h
