On Thu, Jul 02, 2020 at 10:47:00PM +0800, Wei Yongjun wrote: > Fix sparse build warning: > > kernel/scftorture.c:124:1: warning: > symbol '__pcpu_scope_scf_torture_rand' was not declared. Should it be static? > > Reported-by: Hulk Robot <hul...@huawei.com> > Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
Good catch, applied, thank you! Due to recent changes, I hand-applied this as shown below. Please let me know if I messed anything up. Thanx, Paul ------------------------------------------------------------------------ commit ff9210137b0b8d8f045dd1fd116253ba7686e892 Author: Wei Yongjun <weiyongj...@huawei.com> Date: Thu Jul 2 09:56:50 2020 -0700 scftorture: Make symbol 'scf_torture_rand' static The sparse tool complains as follows kernel/scftorture.c:124:1: warning: symbol '__pcpu_scope_scf_torture_rand' was not declared. Should it be static? And this per-CPU variable is not used outside of scftorture.c, so this commit marks it static. Reported-by: Hulk Robot <hul...@huawei.com> Signed-off-by: Wei Yongjun <weiyongj...@huawei.com> Signed-off-by: Paul E. McKenney <paul...@kernel.org> diff --git a/kernel/scftorture.c b/kernel/scftorture.c index 52f74f1..a7fea76 100644 --- a/kernel/scftorture.c +++ b/kernel/scftorture.c @@ -134,7 +134,7 @@ static atomic_t n_alloc_errs; static bool scfdone; static char *bangstr = ""; -DEFINE_TORTURE_RANDOM_PERCPU(scf_torture_rand); +static DEFINE_TORTURE_RANDOM_PERCPU(scf_torture_rand); // Print torture statistics. Caller must ensure serialization. static void scf_torture_stats_print(void)