Thomas Gleixner <[EMAIL PROTECTED]> writes: > On Thu, 25 Oct 2007, Huang, Ying wrote: > >> This patch adds basic runtime services support for EFI x86_64 >> system. The main file of the patch is the addition of efi.c for >> x86_64. This file is modeled after the EFI IA32 avatar. > > modeled means copied and modified, right? > > This is wrong. I compared efi_32.c and efi_64.c and a large amount of > the code is simply the same. The small details can be sorted out by > two sets of macros/inline functions easily. > > Please fix this up.
I don't think there is a compelling case for us to use any efi services at this time so unification should be easy: rm arch/x86/kernel/efi_32.c arch/x86/kernel/efi_stub_32.c Especially for accessing the real time clock that has a well defined hardware interface going through efi an additional software emulation layer looks like asking for trouble. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
