On Thu, Jul 09, 2020 at 02:51:13PM -0700, David Rientjes wrote: > On Thu, 9 Jul 2020, Nicolas Saenz Julienne wrote: > > > The function is only used once and can be simplified to a one-liner. > > > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulie...@suse.de> > > I'll leave this one to Christoph to decide on. One thing I really liked > about hacking around in kernel/dma is the coding style, it really follows > "one function does one thing and does it well" even if there is only one > caller. dma_in_atomic_pool() was an attempt to follow in those footsteps.
While I like the helper aswell, I don't see how it could work nicely with the changes in patch 4.
