On Mon, Jul 13, 2020 at 12:03:36PM +0800, Qiwu Huang wrote: > From: Qiwu Huang <huangq...@xiaomi.com> > > Reports the kind of quick charge type based on > different adapter power. UI will show different > animation effect for different quick charge type. > > Signed-off-by: Qiwu Huang <huangq...@xiaomi.com> > --- > Documentation/ABI/testing/sysfs-class-power | 10 ++++++++++ > drivers/power/supply/power_supply_sysfs.c | 1 + > include/linux/power_supply.h | 1 + > 3 files changed, 12 insertions(+)
What changed from v1 of this patch? SHouldn't that always be below the --- line? > > diff --git a/Documentation/ABI/testing/sysfs-class-power > b/Documentation/ABI/testing/sysfs-class-power > index 216d61a22f1e..d3169d47e359 100644 > --- a/Documentation/ABI/testing/sysfs-class-power > +++ b/Documentation/ABI/testing/sysfs-class-power > @@ -708,3 +708,13 @@ Description: > > Access: Read > Valid values: 1-31 > + > +What: /sys/class/power_supply/<supply_name>/quick_charge_type > +Date: Jul 2020 > +Contact: Fei Jiang <jiangf...@xiaomi.com> > + Description: > + Reports the kind of quick charge type based on different > adapter power. What are the allowed types here? Shouldn't that also be an enumerated type with a predefined string? thanks, greg k-h
