From: Liu Shixin <liushix...@huawei.com>

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: Liu Shixin <liushix...@huawei.com>
---
 drivers/block/rsxx/core.c | 31 ++++---------------------------
 1 file changed, 4 insertions(+), 27 deletions(-)

diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c
index e631749e1..9c35fa35b 100644
--- a/drivers/block/rsxx/core.c
+++ b/drivers/block/rsxx/core.c
@@ -150,16 +150,6 @@ static int rsxx_attr_stats_show(struct seq_file *m, void 
*p)
        return 0;
 }
 
-static int rsxx_attr_stats_open(struct inode *inode, struct file *file)
-{
-       return single_open(file, rsxx_attr_stats_show, inode->i_private);
-}
-
-static int rsxx_attr_pci_regs_open(struct inode *inode, struct file *file)
-{
-       return single_open(file, rsxx_attr_pci_regs_show, inode->i_private);
-}
-
 static ssize_t rsxx_cram_read(struct file *fp, char __user *ubuf,
                              size_t cnt, loff_t *ppos)
 {
@@ -206,21 +196,8 @@ static const struct file_operations debugfs_cram_fops = {
        .write          = rsxx_cram_write,
 };
 
-static const struct file_operations debugfs_stats_fops = {
-       .owner          = THIS_MODULE,
-       .open           = rsxx_attr_stats_open,
-       .read_iter              = seq_read_iter,
-       .llseek         = seq_lseek,
-       .release        = single_release,
-};
-
-static const struct file_operations debugfs_pci_regs_fops = {
-       .owner          = THIS_MODULE,
-       .open           = rsxx_attr_pci_regs_open,
-       .read_iter              = seq_read_iter,
-       .llseek         = seq_lseek,
-       .release        = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(rsxx_attr_stats);
+DEFINE_SHOW_ATTRIBUTE(rsxx_attr_pci_regs);
 
 static void rsxx_debugfs_dev_new(struct rsxx_cardinfo *card)
 {
@@ -234,13 +211,13 @@ static void rsxx_debugfs_dev_new(struct rsxx_cardinfo 
*card)
 
        debugfs_stats = debugfs_create_file("stats", 0444,
                                            card->debugfs_dir, card,
-                                           &debugfs_stats_fops);
+                                           &rsxx_attr_stats_fops);
        if (IS_ERR_OR_NULL(debugfs_stats))
                goto failed_debugfs_stats;
 
        debugfs_pci_regs = debugfs_create_file("pci_regs", 0444,
                                               card->debugfs_dir, card,
-                                              &debugfs_pci_regs_fops);
+                                              &rsxx_attr_pci_regs_fops);
        if (IS_ERR_OR_NULL(debugfs_pci_regs))
                goto failed_debugfs_pci_regs;
 
-- 
2.17.1

Reply via email to