On Tue, Jul 21, 2020 at 3:38 PM Mattijs Korpershoek <mkorpersh...@baylibre.com> wrote: > Fengping yu <fengping...@mediatek.com> writes:
> > This adds matrix keypad support for Mediatek SoCs. ... > > + keypad->regmap = devm_regmap_init_mmio(&pdev->dev, > > + keypad->base, > > + &keypad_regmap_cfg); > > + if (IS_ERR(keypad->regmap)) { > > + dev_err(&pdev->dev, > > + "regmap init failed:%ld\n", PTR_ERR(keypad->regmap)); > > + return PTR_ERR(keypad->regmap); > > + } Okay, because another comment appeared, I would suggest to switch to %pe at the same time. dev_err(&pdev->dev, "regmap init failed: %pe\n", keypad->regmap); -- With Best Regards, Andy Shevchenko