On Tue 21 Jul 03:44 PDT 2020, Shaik Sajida Bhanu wrote: > From: Veerabhadrarao Badiganti <[email protected]> > > On some sc7180 based platforms where external pull is not present on cd-gpio, > this gpio state is getting read as HIGH when sleep config is applied on it. > This is resulting in SDcard rescan after suspend-resume even though SDcard > is not present. >
This is exactly why pinconf properties (such as bias, drive-strength) should be defined in the board specific file. Please move the "pinconf-sd-cd" node to sc7180-idp.dts. Regards, Bjorn > Update cd-gpio sleep config with bais-pull to fix this issue. > > Signed-off-by: Veerabhadrarao Badiganti <[email protected]> > Signed-off-by: Shaik Sajida Bhanu <[email protected]> > --- > > Changes since V1: > - Incorporated review comments by Bjorn Andersson. > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index d78a066..a3527c3 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -1819,7 +1819,7 @@ > > pinconf-sd-cd { > pins = "gpio69"; > - bias-disable; > + bias-pull-up; > drive-strength = <2>; > }; > }; > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation >
