Hi Srinivas, Thank you for the patch! Yet something to improve:
[auto build test ERROR on gpio/for-next] [also build test ERROR on linus/master v5.8-rc6 next-20200723] [cannot apply to xlnx/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Srinivas-Neeli/gpio-xilinx-Update-on-xilinx-gpio-driver/20200723-220826 base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next config: x86_64-randconfig-a003-20200723 (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): drivers/gpio/gpio-xilinx.c: In function 'xgpio_xlate': >> drivers/gpio/gpio-xilinx.c:325:8: error: 'struct gpio_chip' has no member >> named 'of_gpio_n_cells' 325 | if (gc->of_gpio_n_cells < 2) { | ^~ In file included from arch/x86/include/asm/bug.h:92, from include/linux/bug.h:5, from include/linux/thread_info.h:12, from arch/x86/include/asm/preempt.h:7, from include/linux/preempt.h:78, from include/linux/spinlock.h:51, from include/linux/seqlock.h:36, from include/linux/time.h:6, from include/linux/stat.h:19, from include/linux/module.h:13, from drivers/gpio/gpio-xilinx.c:11: drivers/gpio/gpio-xilinx.c:330:39: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells' 330 | if (WARN_ON(gpiospec->args_count < gc->of_gpio_n_cells)) | ^~ include/asm-generic/bug.h:118:25: note: in definition of macro 'WARN_ON' 118 | int __ret_warn_on = !!(condition); \ | ^~~~~~~~~ drivers/gpio/gpio-xilinx.c: In function 'xgpio_probe': drivers/gpio/gpio-xilinx.c:638:10: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells' 638 | chip->gc.of_gpio_n_cells = cells; | ^ >> drivers/gpio/gpio-xilinx.c:639:10: error: 'struct gpio_chip' has no member >> named 'of_xlate' 639 | chip->gc.of_xlate = xgpio_xlate; | ^ vim +325 drivers/gpio/gpio-xilinx.c 312 313 /** 314 * xgpio_xlate - Translate gpio_spec to the GPIO number and flags 315 * @gc: Pointer to gpio_chip device structure. 316 * @gpiospec: gpio specifier as found in the device tree 317 * @flags: A flags pointer based on binding 318 * 319 * Return: 320 * irq number otherwise -EINVAL 321 */ 322 static int xgpio_xlate(struct gpio_chip *gc, 323 const struct of_phandle_args *gpiospec, u32 *flags) 324 { > 325 if (gc->of_gpio_n_cells < 2) { 326 WARN_ON(1); 327 return -EINVAL; 328 } 329 330 if (WARN_ON(gpiospec->args_count < gc->of_gpio_n_cells)) 331 return -EINVAL; 332 333 if (gpiospec->args[0] >= gc->ngpio) 334 return -EINVAL; 335 336 if (flags) 337 *flags = gpiospec->args[1]; 338 339 return gpiospec->args[0]; 340 } 341 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
