On Sun, 2020-07-26 at 18:21 +0100, Al Viro wrote:
> On Tue, Jul 14, 2020 at 03:02:58PM +0800, zhouchuangao wrote:
> > Fix code style errors reported by scripts/checkpatch.pl.
>
> NAKed-because: excessive deference to checkpatch.pl
>
> It's not a holy oracle than needs to be appeased, no questions
> asked. Reference to it is absolutely insufficient reason for
> _anything_ - in effect your commit message could've been
> "just because" for all the information it contains.
Al is right.
Something that could useful is to avoid using printks without
a KERN_<LEVEL> or add KERN_CONT to some continuation printks.
Maybe:
---
diff --git a/init/do_mounts.c b/init/do_mounts.c
index 4f4ceb358055..3f37d859cf2a 100644
--- a/init/do_mounts.c
+++ b/init/do_mounts.c
@@ -468,8 +468,8 @@ void __init mount_block_root(char *name, int flags)
printk_all_partitions();
printk("No filesystem could mount root, tried: ");
for (p = fs_names; *p; p += strlen(p)+1)
- printk(" %s", p);
- printk("\n");
+ pr_cont(" %s", p);
+ pr_cont("\n");
panic("VFS: Unable to mount root fs on %s", b);
out:
put_page(page);
