On Tue, Jul 28, 2020 at 6:15 PM Daniel Campello <campe...@chromium.org> wrote:
>
> Use __aligned(8) to ensure that the timestamp is correctly aligned
> when we call push_to_buffers
>
> Signed-off-by: Daniel Campello <campe...@chromium.org>
> ---
>
> drivers/iio/proximity/sx9310.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/proximity/sx9310.c b/drivers/iio/proximity/sx9310.c
> index de52afd7c13333..fb5c16f2aa6b1a 100644
> --- a/drivers/iio/proximity/sx9310.c
> +++ b/drivers/iio/proximity/sx9310.c
> @@ -131,8 +131,8 @@ struct sx9310_data {
> */
> bool prox_stat[SX9310_NUM_CHANNELS];
> bool trigger_enabled;
> - __be16 buffer[SX9310_NUM_CHANNELS +
> - 4]; /* 64-bit data + 64-bit timestamp */
> + /* 64-bit data + 64-bit timestamp buffer */
> + __be16 buffer[SX9310_NUM_CHANNELS + 4] __aligned(8);
If the data amount (channels) is always the same, please, use struct approach.
Otherwise put a comment explaining dynamic data.
--
With Best Regards,
Andy Shevchenko
