On 2020/7/31 0:25, Jakub Kicinski wrote:
> On Thu, 30 Jul 2020 16:37:15 +0800 Luo bin wrote:
>> +bool check_vf_mbox_random_id(struct hinic_mbox_func_to_func *func_to_func,
>> + u8 *header)
>
> This set seems to add new W=1 C=1 warnings:
>
> drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:572:6: warning: no previous
> prototype for ‘check_vf_mbox_random_id’ [-Wmissing-prototypes]
> 572 | bool check_vf_mbox_random_id(struct hinic_mbox_func_to_func
> *func_to_func,
> | ^~~~~~~~~~~~~~~~~~~~~~~
>
> drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:1352:28: warning: symbol
> 'hw_cmd_support_vf' was not declared. Should it be static?
> .
>
Will fix. Thanks for your review.