> > > > Do the checks for the opportunities for kvmalloc really belong in this > > rule? That issue is not mentioned in the commit log or the description of > > the semantic patch. > > I added this at the last moment. It was easy enough to add it based on > existing > patterns. I will add description for this warnings. Or do you want me to > single > out this warning to a separate rule?
It seems like a different issue. A separate rule might be better. Also, there is no patch variant, so if one runs the patch mode on this script, where the patch mode is useful, then one will miss the kvmalloc suggestions completely. Coccicheck has a mode where is first tries patch and then report; I think 0-day uses this. julia
