On Thu, 01 Nov 2007 19:20:07 +0100
Tilman Schmidt <[EMAIL PROTECTED]> wrote:
> >> +static int gigaset_suspend(struct usb_interface *intf, pm_message_t
> >> message)
> >> +{
> >> + struct cardstate *cs;
> >> + struct usb_cardstate *ucs;
> >> +
> >> + if ((cs = usb_get_intfdata(intf)) == NULL ||
> >> + (ucs = cs->hw.usb) == NULL) {
> >> + err("%s: no cardstate", __func__);
> >> + return -EFAULT;
> >> + }
> >
> > Is the above reeeeeely needed? I bet it never happens.
>
> I'm a great believer in defensive programming. :-)
>
> Anyway, to be sure these checks aren't needed, I would need the
> assurance that the suspend and resume methods are serialized with
> the probe and disconnect methods. Are they?
dunno it beats me. Not to my knowledge. Perhaps Greg and Rafael would know?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
