My comments inline. Thanks, Ilia Lin
On Tue, Aug 4, 2020 at 10:24 PM Andrew Lunn <and...@lunn.ch> wrote: > > On Tue, Aug 04, 2020 at 08:47:18PM +0300, Ilia Lin wrote: > > Hi Andrew and David, > > Hi Ilia > > Please don't top post. > > > > > Thank you for your comments! > > > > The client driver is still work in progress, but it can be seen here: > > https://source.codeaurora.org/quic/la/kernel/msm-4.19/tree/drivers/platform/msm/ipa/ipa_api.c#n3842 > > > > For HW performance reasons, it has to be in subsys_initcall. > > Well, until the user of this new API is ready, we will not accept the > patch. OK, but once we submit the change in the driver, is it good to go? > > You also need to explain "For HW performance reasons". Why is this > driver special that it can do things which no over driver does? There are very strict KPI requirements. E.g. automotive rear mirror must be online 3 sec since boot. > > And you should really be working on net-next, not this dead kernel > version, if you want to get merged into mainline. Of course, the upstream submition will be done on the mainline. I just gave an example of an existing product driver. > > Network drivers do not belong is drivers/platform. There is also ready > a drivers/net/ipa, so i assume you will move there. Sure, the driver in the drivers/net/ipa is the one that will be updated in the future. > > Andrew
