Hi Sylwester, On 8/7/20 1:06 AM, Sylwester Nawrocki wrote: > In the .set_rate callback for some PLLs there is a loop polling state > of the PLL lock bit and it may become an endless loop when something > goes wrong with the PLL. For some PLLs there is already (duplicated) > code for polling with a timeout. This patch refactors that code a bit > and moves it to a common helper function which is then used > in .set_rate callbacks for all the PLLs. > > Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> > --- > drivers/clk/samsung/clk-pll.c | 94 +++++++++++++---------------------- > 1 file changed, 35 insertions(+), 59 deletions(-) >
(snip) It fix the infinite loop and unify the duplicate code. It looks good to me. Thanks. Acked-by: Chanwoo Choi <cw00.c...@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics
