On 8/10/20 11:36 AM, Grant Peltier wrote:
> Per the RAA228228 datasheet, READ_TEMPERATURE_1 is not a supported PMBus
> command.
> 
> Signed-off-by: Grant Peltier <[email protected]>

Please copy [email protected] on hwmon patches. This patch is not
in the hwmon patchwork, which in general almost guarantees that it gets lost
since I usually pull patches from there. As it happens, you are lucky
that I noticed. Patch applied.

Guenter

> ---
>  drivers/hwmon/pmbus/isl68137.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
> index 0c622711ef7e..58aa95a3c010 100644
> --- a/drivers/hwmon/pmbus/isl68137.c
> +++ b/drivers/hwmon/pmbus/isl68137.c
> @@ -67,6 +67,7 @@ enum variants {
>       raa_dmpvr1_2rail,
>       raa_dmpvr2_1rail,
>       raa_dmpvr2_2rail,
> +     raa_dmpvr2_2rail_nontc,
>       raa_dmpvr2_3rail,
>       raa_dmpvr2_hv,
>  };
> @@ -241,6 +242,10 @@ static int isl68137_probe(struct i2c_client *client,
>               info->pages = 1;
>               info->read_word_data = raa_dmpvr2_read_word_data;
>               break;
> +     case raa_dmpvr2_2rail_nontc:
> +             info->func[0] &= ~PMBUS_HAVE_TEMP;
> +             info->func[1] &= ~PMBUS_HAVE_TEMP;
> +             fallthrough;
>       case raa_dmpvr2_2rail:
>               info->pages = 2;
>               info->read_word_data = raa_dmpvr2_read_word_data;
> @@ -304,7 +309,7 @@ static const struct i2c_device_id raa_dmpvr_id[] = {
>       {"raa228000", raa_dmpvr2_hv},
>       {"raa228004", raa_dmpvr2_hv},
>       {"raa228006", raa_dmpvr2_hv},
> -     {"raa228228", raa_dmpvr2_2rail},
> +     {"raa228228", raa_dmpvr2_2rail_nontc},
>       {"raa229001", raa_dmpvr2_2rail},
>       {"raa229004", raa_dmpvr2_2rail},
>       {}
> 

Reply via email to