Hi Al, I love your patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing] [also build test WARNING on linux/master linus/master v5.8 next-20200812] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Al-Cooper/usb-Add-driver-for-USB-signal-re-mapper/20200813-042328 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All warnings (new ones prefixed by >>): >> drivers/usb/host/brcmstb-usb-pinmap.c:219:6: warning: no previous prototype >> for 'sync_all_pins' [-Wmissing-prototypes] 219 | void sync_all_pins(struct brcmstb_usb_pinmap_data *pdata) | ^~~~~~~~~~~~~ vim +/sync_all_pins +219 drivers/usb/host/brcmstb-usb-pinmap.c 06f59ffd15dd0d5 Al Cooper 2020-08-12 218 06f59ffd15dd0d5 Al Cooper 2020-08-12 @219 void sync_all_pins(struct brcmstb_usb_pinmap_data *pdata) 06f59ffd15dd0d5 Al Cooper 2020-08-12 220 { 06f59ffd15dd0d5 Al Cooper 2020-08-12 221 struct out_pin *pout; 06f59ffd15dd0d5 Al Cooper 2020-08-12 222 struct in_pin *pin; 06f59ffd15dd0d5 Al Cooper 2020-08-12 223 int val; 06f59ffd15dd0d5 Al Cooper 2020-08-12 224 int x; 06f59ffd15dd0d5 Al Cooper 2020-08-12 225 06f59ffd15dd0d5 Al Cooper 2020-08-12 226 /* 06f59ffd15dd0d5 Al Cooper 2020-08-12 227 * Enable the override, clear any changed condition and 06f59ffd15dd0d5 Al Cooper 2020-08-12 228 * propagate the state to the GPIO for all out pins. 06f59ffd15dd0d5 Al Cooper 2020-08-12 229 */ 06f59ffd15dd0d5 Al Cooper 2020-08-12 230 pout = pdata->out_pins; 06f59ffd15dd0d5 Al Cooper 2020-08-12 231 for (x = 0; x < pdata->out_count; x++) { 06f59ffd15dd0d5 Al Cooper 2020-08-12 232 pinmap_set(pdata->regs, pout->enable_mask); 06f59ffd15dd0d5 Al Cooper 2020-08-12 233 pinmap_set(pdata->regs, pout->clr_changed_mask); 06f59ffd15dd0d5 Al Cooper 2020-08-12 234 pinmap_unset(pdata->regs, pout->clr_changed_mask); 06f59ffd15dd0d5 Al Cooper 2020-08-12 235 val = readl(pdata->regs) & pout->value_mask; 06f59ffd15dd0d5 Al Cooper 2020-08-12 236 gpiod_set_value(pout->gpiod, val ? 1 : 0); 06f59ffd15dd0d5 Al Cooper 2020-08-12 237 pout++; 06f59ffd15dd0d5 Al Cooper 2020-08-12 238 } 06f59ffd15dd0d5 Al Cooper 2020-08-12 239 06f59ffd15dd0d5 Al Cooper 2020-08-12 240 /* sync and enable all in pins. */ 06f59ffd15dd0d5 Al Cooper 2020-08-12 241 pin = pdata->in_pins; 06f59ffd15dd0d5 Al Cooper 2020-08-12 242 for (x = 0; x < pdata->in_count; x++) { 06f59ffd15dd0d5 Al Cooper 2020-08-12 243 sync_in_pin(pin); 06f59ffd15dd0d5 Al Cooper 2020-08-12 244 pinmap_set(pdata->regs, pin->enable_mask); 06f59ffd15dd0d5 Al Cooper 2020-08-12 245 pin++; 06f59ffd15dd0d5 Al Cooper 2020-08-12 246 } 06f59ffd15dd0d5 Al Cooper 2020-08-12 247 } 06f59ffd15dd0d5 Al Cooper 2020-08-12 248 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
