On 18.08.20 06:04, Ritesh Harjani wrote:
> task_struct addr in lx-ps cmd seems helpful
>
> <e.g. o/p>
> TASK PID COMM
> 0xffffffff82c2b8c0 0 swapper/0
> 0xffff888a0ba20040 1 systemd
> 0xffff888a0ba24040 2 kthreadd
> 0xffff888a0ba28040 3 rcu_gp
>
> Signed-off-by: Ritesh Harjani <rite...@linux.ibm.com>
> ---
> scripts/gdb/linux/tasks.py | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/gdb/linux/tasks.py b/scripts/gdb/linux/tasks.py
> index 0301dc1e0138..17ec19e9b5bf 100644
> --- a/scripts/gdb/linux/tasks.py
> +++ b/scripts/gdb/linux/tasks.py
> @@ -73,11 +73,12 @@ class LxPs(gdb.Command):
> super(LxPs, self).__init__("lx-ps", gdb.COMMAND_DATA)
>
> def invoke(self, arg, from_tty):
> + gdb.write("{:>10} {:>12} {:>7}\n".format("TASK", "PID", "COMM"))
> for task in task_lists():
> - gdb.write("{address} {pid} {comm}\n".format(
> - address=task,
> - pid=task["pid"],
> - comm=task["comm"].string()))
> + gdb.write("{} {:^5} {}\n".format(
> + task.format_string().split()[0],
> + task["pid"].format_string(),
> + task["comm"].string()))
>
>
> LxPs()
>
This patch is confusing me. We already dump the task address. What the
patch changes is adding a header and some conversions of the values. Can
you elaborate?
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
