> > +#include <linux/io.h> > > + > > +#define DLB2_PCI_REG_READ(addr) ioread32(addr) > > +#define DLB2_PCI_REG_WRITE(reg, value) iowrite32(value, reg) > > Why create a macro that is larger than the native call, this saves > nothing except make the reviewer wonder what in the world is happening. > > Just use the real call.
Sure, I'll change this in v3. I'll wait for more reviews before re-submitting. Thanks, Gage
