On 8/25/20 10:51, Alex Dewar wrote:
> Commit 36a8f01cd24b ("IB/qib: Add congestion control agent implementation")
> erroneously marked a couple of switch cases as /* FALLTHROUGH */, which
> were later converted to fallthrough statements by commit df561f6688fe
> ("treewide: Use fallthrough pseudo-keyword"). This triggered a Coverity
> warning about unreachable code.
>
> Remove the fallthrough statements and replace the mass of gotos with
> simple return statements to make the code terser and less bug-prone.
>
This should be split up into two separate patches: one to address the
fallthrough markings, and another one for the gotos.
Thanks
--
Gustavo
- [PATCH] IB/qib: remove superfluous fallthrough stateme... Alex Dewar
- Re: [PATCH] IB/qib: remove superfluous fallthroug... Gustavo A. R. Silva
- Re: [PATCH] IB/qib: remove superfluous fallth... Joe Perches
- Re: [PATCH] IB/qib: remove superfluous fa... Gustavo A. R. Silva
- Re: [PATCH] IB/qib: remove superfluou... Joe Perches
- Re: [PATCH] IB/qib: remove super... Gustavo A. R. Silva
- Re: [PATCH] IB/qib: remove s... Joe Perches
- Re: [PATCH] IB/qib: remove superfluou... Alex Dewar
- [PATCH v2 2/2] IB/qib: tidy up p... Alex Dewar
- [PATCH v2 1/2] IB/qib: remove su... Alex Dewar
- Re: [PATCH v2 1/2] IB/qib: r... Gustavo A. R. Silva
- Re: [PATCH v2 1/2] IB/qi... Gustavo A. R. Silva

