Hi, On Tue, Aug 25, 2020 at 3:27 PM Rob Clark <robdcl...@gmail.com> wrote: > > + max98357a: audio-codec-0 { > + compatible = "maxim,max98357a"; > + pinctrl-names = "default"; > + pinctrl-0 = <&_en>; > + sdmode-gpios = <&tlmm 23 GPIO_ACTIVE_HIGH>; > + #sound-dai-cells = <0>; > + };
Even though Device Tree spec says "audio-codec", I agree that "audio-codec-0" should be fine. Since this is at the top level that could be important to disambiguate if there was more than one audio codec. > +&wifi { > + status = "okay"; > + vdd-0.8-cx-mx-supply = <&vdd_cx_wlan>; > + vdd-1.8-xo-supply = <&pp1800_l1c>; > + vdd-1.3-rfa-supply = <&pp1300_l2c>; Sorry, I should have been clearer. Here you should add: vdd-3.3-ch0-supply = <&pp3300_l10c>; vdd-3.3-ch1-supply = <&pp3300_l11c>; ...the hack that was downstream was to stick the "ch1" regulator in the "ch0" slot since Bluetooth was already holding the "ch0" regulator open and the "ch1" wasn't part of the bindings yet. Once the supplies are added for WiFi feel free to add my Reviewed-by tag. -Doug