Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <k...@kernel.org>
---
 drivers/iio/magnetometer/ak8974.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/iio/magnetometer/ak8974.c 
b/drivers/iio/magnetometer/ak8974.c
index cbb44e401c0a..fa6a8e1a815c 100644
--- a/drivers/iio/magnetometer/ak8974.c
+++ b/drivers/iio/magnetometer/ak8974.c
@@ -843,15 +843,9 @@ static int ak8974_probe(struct i2c_client *i2c,
        ret = devm_regulator_bulk_get(&i2c->dev,
                                      ARRAY_SIZE(ak8974->regs),
                                      ak8974->regs);
-       if (ret < 0) {
-               if (ret != -EPROBE_DEFER)
-                       dev_err(&i2c->dev, "cannot get regulators: %d\n", ret);
-               else
-                       dev_dbg(&i2c->dev,
-                               "regulators unavailable, deferring probe\n");
-
-               return ret;
-       }
+       if (ret < 0)
+               return dev_err_probe(&i2c->dev, ret,
+                                    "cannot get regulators\n");
 
        ret = regulator_bulk_enable(ARRAY_SIZE(ak8974->regs), ak8974->regs);
        if (ret < 0) {
-- 
2.17.1

Reply via email to