Hi Chunguang, Thank you for the patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on scsi/for-next block/for-next linus/master asm-generic/master v5.9-rc2 next-20200827] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Chunguang-Xu/clean-up-the-code-related-to-ASSERT/20200827-182148 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: x86_64-randconfig-a013-20200827 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 71f3169e1baeff262583b35ef88f8fb6df7be85e) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): net/rxrpc/rxkad.c:344:33: warning: format specifies type 'unsigned short' but the argument has type 'u32' (aka 'unsigned int') [-Wformat] _leave(" = %d [set %hx]", ret, y); ~~~ ^ %x net/rxrpc/ar-internal.h:1150:16: note: expanded from macro '_leave' kleave(FMT,##__VA_ARGS__); \ ~~~ ^~~~~~~~~~~ net/rxrpc/ar-internal.h:1121:63: note: expanded from macro 'kleave' #define kleave(FMT,...) dbgprintk("<== %s()"FMT"",__func__ ,##__VA_ARGS__) ~~~ ^~~~~~~~~~~ net/rxrpc/ar-internal.h:1118:46: note: expanded from macro 'dbgprintk' printk("[%-6.6s] "FMT"\n", current->comm ,##__VA_ARGS__) ~~~ ^~~~~~~~~~~ >> net/rxrpc/rxkad.c:930:2: error: use of undeclared identifier 'x' ASSERT(conn->server_key->payload.data[0] != NULL); ^ net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT' #define ASSERT(X) ASSERT_FAIL(x) ^ >> net/rxrpc/rxkad.c:930:2: error: use of undeclared identifier 'x' net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT' #define ASSERT(X) ASSERT_FAIL(x) ^ 1 warning and 2 errors generated. # https://github.com/0day-ci/linux/commit/1d215ffa42c9e100fa23c485351acf9293936807 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Chunguang-Xu/clean-up-the-code-related-to-ASSERT/20200827-182148 git checkout 1d215ffa42c9e100fa23c485351acf9293936807 vim +/x +930 net/rxrpc/rxkad.c 17926a79320afa David Howells 2007-04-26 890 17926a79320afa David Howells 2007-04-26 891 /* 17926a79320afa David Howells 2007-04-26 892 * decrypt the kerberos IV ticket in the response 17926a79320afa David Howells 2007-04-26 893 */ 17926a79320afa David Howells 2007-04-26 894 static int rxkad_decrypt_ticket(struct rxrpc_connection *conn, fb46f6ee10e787 David Howells 2017-04-06 895 struct sk_buff *skb, 17926a79320afa David Howells 2007-04-26 896 void *ticket, size_t ticket_len, 17926a79320afa David Howells 2007-04-26 897 struct rxrpc_crypt *_session_key, 10674a03c63337 Baolin Wang 2017-08-29 898 time64_t *_expiry, 17926a79320afa David Howells 2007-04-26 899 u32 *_abort_code) 17926a79320afa David Howells 2007-04-26 900 { 1afe593b423918 Herbert Xu 2016-01-24 901 struct skcipher_request *req; fb46f6ee10e787 David Howells 2017-04-06 902 struct rxrpc_skb_priv *sp = rxrpc_skb(skb); 17926a79320afa David Howells 2007-04-26 903 struct rxrpc_crypt iv, key; 68e3f5dd4db626 Herbert Xu 2007-10-27 904 struct scatterlist sg[1]; 17926a79320afa David Howells 2007-04-26 905 struct in_addr addr; 95c961747284a6 Eric Dumazet 2012-04-15 906 unsigned int life; fb46f6ee10e787 David Howells 2017-04-06 907 const char *eproto; 10674a03c63337 Baolin Wang 2017-08-29 908 time64_t issue, now; 17926a79320afa David Howells 2007-04-26 909 bool little_endian; 17926a79320afa David Howells 2007-04-26 910 int ret; fb46f6ee10e787 David Howells 2017-04-06 911 u32 abort_code; 17926a79320afa David Howells 2007-04-26 912 u8 *p, *q, *name, *end; 17926a79320afa David Howells 2007-04-26 913 17926a79320afa David Howells 2007-04-26 914 _enter("{%d},{%x}", conn->debug_id, key_serial(conn->server_key)); 17926a79320afa David Howells 2007-04-26 915 17926a79320afa David Howells 2007-04-26 916 *_expiry = 0; 17926a79320afa David Howells 2007-04-26 917 17926a79320afa David Howells 2007-04-26 918 ret = key_validate(conn->server_key); 17926a79320afa David Howells 2007-04-26 919 if (ret < 0) { 17926a79320afa David Howells 2007-04-26 920 switch (ret) { 17926a79320afa David Howells 2007-04-26 921 case -EKEYEXPIRED: fb46f6ee10e787 David Howells 2017-04-06 922 abort_code = RXKADEXPIRED; ef68622da9cc0c David Howells 2017-04-06 923 goto other_error; 17926a79320afa David Howells 2007-04-26 924 default: fb46f6ee10e787 David Howells 2017-04-06 925 abort_code = RXKADNOAUTH; ef68622da9cc0c David Howells 2017-04-06 926 goto other_error; 17926a79320afa David Howells 2007-04-26 927 } 17926a79320afa David Howells 2007-04-26 928 } 17926a79320afa David Howells 2007-04-26 929 146aa8b1453bd8 David Howells 2015-10-21 @930 ASSERT(conn->server_key->payload.data[0] != NULL); 17926a79320afa David Howells 2007-04-26 931 ASSERTCMP((unsigned long) ticket & 7UL, ==, 0); 17926a79320afa David Howells 2007-04-26 932 146aa8b1453bd8 David Howells 2015-10-21 933 memcpy(&iv, &conn->server_key->payload.data[2], sizeof(iv)); 17926a79320afa David Howells 2007-04-26 934 ef68622da9cc0c David Howells 2017-04-06 935 ret = -ENOMEM; 1afe593b423918 Herbert Xu 2016-01-24 936 req = skcipher_request_alloc(conn->server_key->payload.data[0], 1afe593b423918 Herbert Xu 2016-01-24 937 GFP_NOFS); ef68622da9cc0c David Howells 2017-04-06 938 if (!req) ef68622da9cc0c David Howells 2017-04-06 939 goto temporary_error; 17926a79320afa David Howells 2007-04-26 940 68e3f5dd4db626 Herbert Xu 2007-10-27 941 sg_init_one(&sg[0], ticket, ticket_len); 1afe593b423918 Herbert Xu 2016-01-24 942 skcipher_request_set_callback(req, 0, NULL, NULL); 1afe593b423918 Herbert Xu 2016-01-24 943 skcipher_request_set_crypt(req, sg, sg, ticket_len, iv.x); 1afe593b423918 Herbert Xu 2016-01-24 944 crypto_skcipher_decrypt(req); 1afe593b423918 Herbert Xu 2016-01-24 945 skcipher_request_free(req); 17926a79320afa David Howells 2007-04-26 946 17926a79320afa David Howells 2007-04-26 947 p = ticket; 17926a79320afa David Howells 2007-04-26 948 end = p + ticket_len; 17926a79320afa David Howells 2007-04-26 949 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
