On Thu, Aug 27, 2020 at 10:28 PM Krzysztof Kozlowski <k...@kernel.org> wrote: > > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value.
Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> > Signed-off-by: Krzysztof Kozlowski <k...@kernel.org> > --- > drivers/iio/adc/meson_saradc.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c > index 93c2252c0b89..a9d06e8a576a 100644 > --- a/drivers/iio/adc/meson_saradc.c > +++ b/drivers/iio/adc/meson_saradc.c > @@ -719,11 +719,8 @@ static int meson_sar_adc_temp_sensor_init(struct iio_dev > *indio_dev) > if (ret == -ENODEV) > return 0; > > - if (ret != -EPROBE_DEFER) > - dev_err(indio_dev->dev.parent, > - "failed to get temperature_calib cell\n"); > - > - return ret; > + return dev_err_probe(indio_dev->dev.parent, ret, > + "failed to get temperature_calib > cell\n"); > } > > priv->tsc_regmap = > -- > 2.17.1 > -- With Best Regards, Andy Shevchenko
