Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <k...@kernel.org>
Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com>

---

Changes since v1:
1. Wrap dev_err_probe() lines at 100 character
---
 drivers/iio/light/tsl2772.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/iio/light/tsl2772.c b/drivers/iio/light/tsl2772.c
index 735399405417..d79205361dfa 100644
--- a/drivers/iio/light/tsl2772.c
+++ b/drivers/iio/light/tsl2772.c
@@ -1776,14 +1776,8 @@ static int tsl2772_probe(struct i2c_client *clientp,
        ret = devm_regulator_bulk_get(&clientp->dev,
                                      ARRAY_SIZE(chip->supplies),
                                      chip->supplies);
-       if (ret < 0) {
-               if (ret != -EPROBE_DEFER)
-                       dev_err(&clientp->dev,
-                               "Failed to get regulators: %d\n",
-                               ret);
-
-               return ret;
-       }
+       if (ret < 0)
+               return dev_err_probe(&clientp->dev, ret, "Failed to get 
regulators\n");
 
        ret = regulator_bulk_enable(ARRAY_SIZE(chip->supplies), chip->supplies);
        if (ret < 0) {
-- 
2.17.1

Reply via email to