On Mon, Aug 31, 2020 at 05:23:26PM -0700, Nick Desaulniers wrote: > As Kees suggests, do so provides developers with two useful pieces of > information: > - The kernel build was attempting to use GCC. > (Maybe they accidentally poked the wrong configs in a CI.) > - They need 4.9 or better. > ("Upgrade to what version?" doesn't need to be dug out of documentation, > headers, etc.) > > Suggested-by: Kees Cook <keesc...@chromium.org> > Signed-off-by: Nick Desaulniers <ndesaulni...@google.com>
Reviewed-by: Nathan Chancellor <natechancel...@gmail.com> It would be nice if there was some easy way to link the documentation here so that patches like commit 0bddd227f3dc ("Documentation: update for gcc 4.9 requirement") did not need to happen or be remembered. > --- > include/linux/compiler-gcc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h > index 7a3769040d7d..d1e3c6896b71 100644 > --- a/include/linux/compiler-gcc.h > +++ b/include/linux/compiler-gcc.h > @@ -12,7 +12,7 @@ > > /* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 */ > #if GCC_VERSION < 40900 > -# error Sorry, your compiler is too old - please upgrade it. > +# error Sorry, your version of GCC is too old - please use 4.9 or newer. > #endif > > /* Optimization barrier */ > -- > 2.28.0.402.g5ffc5be6b7-goog >