Christian Brauner <christian.brau...@ubuntu.com> wrote: > On Tue, Sep 01, 2020 at 07:58:00AM -0400, Miaohe Lin wrote: > No functional change intended.
>Hey Miaohe, > >Thank you for the patch. >I'm sure this is well-intended but afaict the whole file has more or less a >consistent style already where e.g. sig-1 without spaces seems to be >preferred. The same for the casts where most places use a single space. > >Now, I know CodingStyle.rst is on your side at least when it comes to the >first point: > >Use one space around (on each side of) most binary and ternary operators, such >as any of these:: > > = + - < > * / % | & ^ <= >= == != ? : > >but then you'd need to change each place in kernel/signal.c where that is >currently not the case. Otherwise we end up with a weird mix. > >Thanks! >Christian > Many thanks for your reply. It looks it's better to make codestyle consistent. Will do it when I'am free. :) Thanks again.
