Hi Shiju,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pm/linux-next]
[also build test ERROR on arm64/for-next/core linux/master linus/master 
v5.9-rc3 next-20200828]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Shiju-Jose/RAS-Add-CPU-Correctable-Error-Collector-to-isolate-an-erroneous-CPU-core/20200901-222704
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git 
linux-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All errors (new ones prefixed by >>):

   drivers/acpi/apei/ghes.c: In function 'ghes_handle_arm_hw_error':
>> drivers/acpi/apei/ghes.c:527:8: error: implicit declaration of function 
>> 'get_logical_index' [-Werror=implicit-function-declaration]
     527 |  cpu = get_logical_index(err->mpidr);
         |        ^~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

# 
https://github.com/0day-ci/linux/commit/5d1b166196baa45a5e541b6c2524e28fdeeeedd8
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review 
Shiju-Jose/RAS-Add-CPU-Correctable-Error-Collector-to-isolate-an-erroneous-CPU-core/20200901-222704
git checkout 5d1b166196baa45a5e541b6c2524e28fdeeeedd8
vim +/get_logical_index +527 drivers/acpi/apei/ghes.c

   513  
   514  static void ghes_handle_arm_hw_error(struct acpi_hest_generic_data 
*gdata)
   515  {
   516          struct cper_sec_proc_arm *err = acpi_hest_get_payload(gdata);
   517          struct cper_arm_err_info *err_info;
   518          int sec_sev;
   519          int cpu, i, ret;
   520  
   521          log_arm_hw_error(err);
   522  
   523          sec_sev = ghes_severity(gdata->error_severity);
   524          if (sec_sev != GHES_SEV_CORRECTED)
   525                  return;
   526  
 > 527          cpu = get_logical_index(err->mpidr);
   528          if (cpu == -EINVAL)
   529                  return;
   530  
   531          err_info = (struct cper_arm_err_info *)(err + 1);
   532          for (i = 0; i < err->err_info_num; i++) {
   533                  ret = cpu_cec_add_ce(cpu, err_info->multiple_error + 1);
   534                  if (ret)
   535                          break;
   536                  err_info += 1;
   537          }
   538  }
   539  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

Reply via email to