Hi Joe,

Nice, I only see three of these on the linux-media list, so I'll only
look at those, but I'm pleased to see this is treewide ;-)

Definitely prefer this.

On 25/08/2020 05:56, Joe Perches wrote:
> Use semicolons and braces.
> 
> Signed-off-by: Joe Perches <j...@perches.com>

Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>

> ---
>  drivers/dma-buf/st-dma-fence.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c
> index e593064341c8..c8a12d7ad71a 100644
> --- a/drivers/dma-buf/st-dma-fence.c
> +++ b/drivers/dma-buf/st-dma-fence.c
> @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg)
>                       dma_fence_signal(f1);
>  
>               smp_store_mb(cb.seen, false);
> -             if (!f2 || dma_fence_add_callback(f2, &cb.cb, simple_callback))
> -                     miss++, cb.seen = true;
> +             if (!f2 ||
> +                 dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
> +                     miss++;
> +                     cb.seen = true;
> +             }
>  
>               if (!t->before)
>                       dma_fence_signal(f1);
> 

Reply via email to