On Mon, 31 Aug 2020, 9:18am, Daniel Wagner wrote:
>
> Commit 7c3df1320e5e ("[SCSI] qla2xxx: Code changes to support new
> dynamic logging infrastructure.") removed the use of the func
> argument.
>
> Signed-off-by: Daniel Wagner <dwag...@suse.de>
> ---
> drivers/scsi/qla2xxx/qla_gbl.h | 3 +--
> drivers/scsi/qla2xxx/qla_isr.c | 36 ++++++++++++------------------------
> drivers/scsi/qla2xxx/qla_mr.c | 9 +++------
> 3 files changed, 16 insertions(+), 32 deletions(-)
>
--8<--
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index 5d278155e4e7..b787643f5031 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -1711,8 +1711,7 @@ qla2x00_process_completed_request(struct scsi_qla_host
> *vha,
> }
>
> srb_t *
> -qla2x00_get_sp_from_handle(scsi_qla_host_t *vha, const char *func,
> - struct req_que *req, void *iocb)
> +qla2x00_get_sp_from_handle(scsi_qla_host_t *vha, struct req_que *req, void
> *iocb)
> {
> struct qla_hw_data *ha = vha->hw;
> sts_entry_t *pkt = iocb;
How about printing the "func", which gives an indication of the caller
function, in the ql_log-s, rather than removing it? At least in the cases
like you describe, it'd give an indication which handler the path was
taken.
Regards,
-Arun
