Hi,
On Fri, Sep 11, 2020 at 12:15 AM Alejandro Colomar
<colomar.6....@gmail.com> wrote:
>
> Signed-off-by: Alejandro Colomar <colomar.6....@gmail.com>
> ---
> man3/getgrent_r.3 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man3/getgrent_r.3 b/man3/getgrent_r.3
> index 81d81a851..76deec370 100644
> --- a/man3/getgrent_r.3
> +++ b/man3/getgrent_r.3
> @@ -186,7 +186,7 @@ main(void)
>
> setgrent();
> while (1) {
> - i = getgrent_r(&grp, buf, BUFLEN, &grpp);
> + i = getgrent_r(&grp, buf, sizeof(buf), &grpp);
I'm worried that less attentive people might copy/paste parts of this
in their code, where maybe buf is just a pointer, and expect it to
work. Maybe leaving BUFLEN here is useful as a reminder that they need
to change something to adapt the code?
Just my 2 cents,
Stefan.
