Tue, Sep 15, 2020 at 12:06:19AM CEST, michael.c...@broadcom.com wrote: >On Mon, Sep 14, 2020 at 2:31 PM Jakub Kicinski <k...@kernel.org> wrote: >> >> On Mon, 14 Sep 2020 13:28:29 +0200 Jiri Pirko wrote: >> > >> Instead, why don't you block in reload_up() until the reset is complete? >> > > >> > >Though user initiate "devlink dev reload" event on a single interface, >> > >all driver entities undergo reset and all entities recover >> > >independently. I don't think we can block the reload_up() on the >> > >interface(that user initiated the command), until whole reset is >> > >complete. >> > >> > Why not? mlxsw reset takes up to like 10 seconds for example. >> >> +1, why? > >Yes, we should be able to block until the reset sequence is complete. >I don't see any problem. I will work with Vasundhara on this.
Could you please also remove fw_reset as it is apparently misuse of devlink health mechanism? Thanks!