On Thu, Sep 17, 2020 at 11:49:04AM +0300, Ilie Halip wrote: > With CONFIG_UBSAN_TRAP enabled, the compiler may insert a trap instruction > after a call to a noreturn function. In this case, objtool warns that the > ud2 instruction is unreachable. > > objtool silences similar warnings (trap after dead end instructions), so > expand that check to include dead end functions. > > Cc: Nick Desaulniers <ndesaulni...@google.com> > Cc: Rong Chen <rong.a.c...@intel.com> > Cc: Marco Elver <el...@google.com> > Cc: Philip Li <philip...@intel.com> > Cc: Borislav Petkov <b...@alien8.de> > Cc: kasan-...@googlegroups.com > Cc: x...@kernel.org > Cc: clang-built-li...@googlegroups.com > BugLink: https://github.com/ClangBuiltLinux/linux/issues/1148 > Link: > https://lore.kernel.org/lkml/CAKwvOdmptEpi8fiOyWUo=aizjix+z+vhjom2bulprwsmtwl...@mail.gmail.com > Suggested-by: Nick Desaulniers <ndesaulni...@google.com> > Signed-off-by: Ilie Halip <ilie.ha...@gmail.com>
The patch looks good to me. Which versions of Clang do the trap after noreturn call? It would be good to have that in the commit message. -- Josh
