Re: [PATCH -next 8/9] rtlwifi: rtl8192de: fix comparison to bool warning in hw.c

[Larry Finger]

On 9/18/20 5:25 AM, Zheng Bin wrote:

Fixes coccicheck warning:

drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:566:14-20: WARNING: 
Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:572:13-19: WARNING: 
Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:581:14-20: WARNING: 
Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:587:13-19: WARNING: 
Comparison to bool

Signed-off-by: Zheng Bin <zhengbi...@huawei.com>
---
  drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

Acked-by: Larry Finger <larry.fin...@lwfinger.net>

Larry

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c 
b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c
index 2deadc7339ce..f849291cc587 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c
@@ -563,13 +563,13 @@ static bool _rtl92de_llt_table_init(struct ieee80211_hw 
*hw)
        /* 18.  LLT_table_init(Adapter);  */
        for (i = 0; i < (txpktbuf_bndy - 1); i++) {
                status = _rtl92de_llt_write(hw, i, i + 1);
-               if (true != status)
+               if (!status)
                        return status;
        }

        /* end of list */
        status = _rtl92de_llt_write(hw, (txpktbuf_bndy - 1), 0xFF);
-       if (true != status)
+       if (!status)
                return status;

        /* Make the other pages as ring buffer */
@@ -578,13 +578,13 @@ static bool _rtl92de_llt_table_init(struct ieee80211_hw 
*hw)
        /* Otherwise used as local loopback buffer.  */
        for (i = txpktbuf_bndy; i < maxpage; i++) {
                status = _rtl92de_llt_write(hw, i, (i + 1));
-               if (true != status)
+               if (!status)
                        return status;
        }

        /* Let last entry point to the start entry of ring buffer */
        status = _rtl92de_llt_write(hw, maxpage, txpktbuf_bndy);
-       if (true != status)
+       if (!status)
                return status;

        return true;
--
2.26.0.106.g9fadedd