From: Alex Deucher <[email protected]> Date: 2020-09-22 03:33:20 To: Bernard Zhao <[email protected]> Cc: Harry Wentland <[email protected]>,Leo Li <[email protected]>,Alex Deucher <[email protected]>,"Christian König" <[email protected]>,David Airlie <[email protected]>,Daniel Vetter <[email protected]>,Rodrigo Siqueira <[email protected]>,Jun Lei <[email protected]>,Aric Cyr <[email protected]>,Wenjing Liu <[email protected]>,abdoulaye berthe <[email protected]>,Michael Strauss <[email protected]>,Brandon Syu <[email protected]>,Martin Leung <[email protected]>,amd-gfx list <[email protected]>,Maling list - DRI developers <[email protected]>,LKML <[email protected]>,[email protected] Subject: Re: [PATCH] drm/amd/display: optimize code runtime a bit>On Mon, Sep 21, 2020 at 9:14 AM Bernard Zhao <[email protected]> wrote: >> >> Static function dal_ddc_i2c_payloads_destroy is only called >> in dal_ddc_service_query_ddc_data, the parameter is &payloads >> , there is no point NULL risk, so no need to check. >> This change is to make the code run a bit fast. >> > >How about just getting rid of dal_ddc_i2c_payloads_destroy() and just >call dal_vector_destruct() directly.
Good idea, I will resubmit a patch, thanks! BR//Bernard >Alex > > >> Signed-off-by: Bernard Zhao <[email protected]> >> --- >> drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c >> b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c >> index b984eecca58b..6dcc666738fc 100644 >> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c >> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c >> @@ -150,9 +150,6 @@ static uint32_t dal_ddc_i2c_payloads_get_count(struct >> i2c_payloads *p) >> >> static void dal_ddc_i2c_payloads_destroy(struct i2c_payloads *p) >> { >> - if (!p) >> - return; >> - >> dal_vector_destruct(&p->payloads); >> } >> >> -- >> 2.28.0 >> >> _______________________________________________ >> amd-gfx mailing list >> [email protected] >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
