Hi Thomas, On Tue, Sep 22, 2020 at 12:58 AM Thomas Gleixner <[email protected]> wrote: > > Sami reported that run_on_irqstack_cond() requires the caller to cast > functions to mismatching types, which trips indirect call Control-Flow > Integrity (CFI) in Clang. > > Instead of disabling CFI on that function, provide proper helpers for > the three call variants. The actual ASM code stays the same as that is > out of reach. > > Reported-by: Sami Tolvanen <[email protected]> > Fixes: 931b94145981 ("x86/entry: Provide helpers for executing on the > irqstack") > Signed-off-by: Thomas Gleixner <[email protected]>
Thank you for the patch! I confirmed that this fixes the type mismatch issue with CFI for me: Tested-by: Sami Tolvanen <[email protected]> Also, please note that this was first reported by Nathan in this GitHub issue: https://github.com/ClangBuiltLinux/linux/issues/1052 Sami
