Hi Nick, Thank you for the patch! Yet something to improve:
[auto build test ERROR on kdave/for-next] [also build test ERROR on f2fs/dev-test linus/master v5.9-rc6 next-20200923] [cannot apply to cryptodev/master crypto/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Nick-Terrell/Update-to-zstd-1-4-6/20200924-064102 base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next config: h8300-randconfig-p002-20200923 (attached as .config) compiler: h8300-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): h8300-linux-ld: lib/zstd/common/entropy_common.o: in function `MEM_swap32': >> lib/zstd/common/mem.h:179: undefined reference to `__bswapsi2' >> h8300-linux-ld: lib/zstd/common/mem.h:179: undefined reference to >> `__bswapsi2' >> h8300-linux-ld: lib/zstd/common/mem.h:179: undefined reference to >> `__bswapsi2' >> h8300-linux-ld: lib/zstd/common/mem.h:179: undefined reference to >> `__bswapsi2' h8300-linux-ld: lib/zstd/common/fse_decompress.o: in function `MEM_swap32': >> lib/zstd/common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/common/fse_decompress.o:lib/zstd/common/mem.h:179: more undefined references to `__bswapsi2' follow h8300-linux-ld: lib/zstd/compress/zstd_compress.o: in function `MEM_swap64': >> lib/zstd/compress/../common/mem.h:192: undefined reference to `__bswapdi2' h8300-linux-ld: lib/zstd/compress/zstd_compress.o: in function `MEM_swap32': >> lib/zstd/compress/../common/mem.h:179: undefined reference to `__bswapsi2' >> h8300-linux-ld: lib/zstd/compress/../common/mem.h:179: undefined reference >> to `__bswapsi2' >> h8300-linux-ld: lib/zstd/compress/../common/mem.h:179: undefined reference >> to `__bswapsi2' >> h8300-linux-ld: lib/zstd/compress/../common/mem.h:179: undefined reference >> to `__bswapsi2' >> h8300-linux-ld: lib/zstd/compress/../common/mem.h:179: undefined reference >> to `__bswapsi2' h8300-linux-ld: lib/zstd/compress/zstd_compress.o:lib/zstd/compress/../common/mem.h:179: more undefined references to `__bswapsi2' follow h8300-linux-ld: lib/zstd/compress/zstd_double_fast.o: in function `MEM_swap64': >> lib/zstd/compress/../common/mem.h:192: undefined reference to `__bswapdi2' >> h8300-linux-ld: lib/zstd/compress/../common/mem.h:192: undefined reference >> to `__bswapdi2' >> h8300-linux-ld: lib/zstd/compress/../common/mem.h:192: undefined reference >> to `__bswapdi2' >> h8300-linux-ld: lib/zstd/compress/../common/mem.h:192: undefined reference >> to `__bswapdi2' >> h8300-linux-ld: lib/zstd/compress/../common/mem.h:192: undefined reference >> to `__bswapdi2' h8300-linux-ld: lib/zstd/compress/zstd_double_fast.o:lib/zstd/compress/../common/mem.h:192: more undefined references to `__bswapdi2' follow h8300-linux-ld: lib/zstd/compress/zstd_opt.o: in function `MEM_swap32': >> lib/zstd/compress/../common/mem.h:179: undefined reference to `__bswapsi2' >> h8300-linux-ld: lib/zstd/compress/../common/mem.h:179: undefined reference >> to `__bswapsi2' h8300-linux-ld: lib/zstd/compress/zstd_opt.o: in function `MEM_swap64': >> lib/zstd/compress/../common/mem.h:192: undefined reference to `__bswapdi2' >> h8300-linux-ld: lib/zstd/compress/../common/mem.h:192: undefined reference >> to `__bswapdi2' h8300-linux-ld: lib/zstd/compress/../common/mem.h:192: undefined reference to `__bswapdi2' h8300-linux-ld: lib/zstd/compress/../common/mem.h:192: undefined reference to `__bswapdi2' h8300-linux-ld: lib/zstd/compress/../common/mem.h:192: undefined reference to `__bswapdi2' h8300-linux-ld: lib/zstd/compress/zstd_opt.o:lib/zstd/compress/../common/mem.h:192: more undefined references to `__bswapdi2' follow h8300-linux-ld: lib/zstd/decompress/huf_decompress.o: in function `MEM_swap32': lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/huf_decompress.o:lib/zstd/decompress/../common/mem.h:179: more undefined references to `__bswapsi2' follow h8300-linux-ld: lib/zstd/decompress/zstd_decompress.o: in function `MEM_swap64': lib/zstd/decompress/../common/mem.h:192: undefined reference to `__bswapdi2' h8300-linux-ld: lib/zstd/decompress/zstd_decompress.o: in function `MEM_swap32': lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/zstd_decompress.o:lib/zstd/decompress/../common/mem.h:179: more undefined references to `__bswapsi2' follow h8300-linux-ld: lib/zstd/decompress/zstd_decompress.o: in function `MEM_swap64': lib/zstd/decompress/../common/mem.h:192: undefined reference to `__bswapdi2' h8300-linux-ld: lib/zstd/decompress/zstd_decompress.o: in function `MEM_swap32': lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/zstd_decompress.o: in function `MEM_swap64': lib/zstd/decompress/../common/mem.h:192: undefined reference to `__bswapdi2' h8300-linux-ld: lib/zstd/decompress/zstd_decompress.o: in function `MEM_swap32': lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/zstd_decompress.o: in function `MEM_swap64': lib/zstd/decompress/../common/mem.h:192: undefined reference to `__bswapdi2' h8300-linux-ld: lib/zstd/decompress/zstd_decompress.o: in function `MEM_swap32': lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/zstd_decompress.o: in function `MEM_swap64': lib/zstd/decompress/../common/mem.h:192: undefined reference to `__bswapdi2' h8300-linux-ld: lib/zstd/decompress/zstd_decompress.o: in function `MEM_swap32': lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/zstd_decompress.o:lib/zstd/decompress/../common/mem.h:179: more undefined references to `__bswapsi2' follow h8300-linux-ld: lib/zstd/decompress/zstd_decompress.o: in function `MEM_swap64': lib/zstd/decompress/../common/mem.h:192: undefined reference to `__bswapdi2' h8300-linux-ld: lib/zstd/decompress/zstd_decompress.o: in function `MEM_swap32': lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/zstd_decompress_block.o: in function `MEM_swap32': lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/../common/mem.h:179: undefined reference to `__bswapsi2' h8300-linux-ld: lib/zstd/decompress/zstd_decompress_block.o:lib/zstd/decompress/../common/mem.h:179: more undefined references to `__bswapsi2' follow cppcheck warnings: (new ones prefixed by >>) >> lib/zstd/decompress/zstd_ddict.c:147:32: warning: Boolean result is used in >> bitwise operation. Clarify expression with parentheses. [clarifyCondition] if (!customMem.customAlloc ^ !customMem.customFree) return NULL; ^ >> lib/zstd/common/zstd_deps.h:131:0: warning: syntax error [syntaxError] ^ >> lib/zstd/compress/zstd_ldm.c:571:0: warning: Array 'rep[3]' accessed at >> index 3, which is out of bounds. [arrayIndexOutOfBounds] ZSTD_blockCompressor const blockCompressor = ^ >> lib/zstd/common/zstd_deps.h:131:0: warning: syntax error [syntaxError] ^ >> lib/zstd/decompress/zstd_decompress.c:133:32: warning: Boolean result is >> used in bitwise operation. Clarify expression with parentheses. >> [clarifyCondition] if (!customMem.customAlloc ^ !customMem.customFree) return NULL; ^ >> lib/zstd/decompress/zstd_decompress.c:1751:28: warning: Variable >> 'zds->inPos' is reassigned a value before the old one has been used. >> [redundantAssignment] zds->inPos = 0; /* input is consumed */ ^ lib/zstd/decompress/zstd_decompress.c:1747:28: note: Variable 'zds->inPos' is reassigned a value before the old one has been used. zds->inPos += loadedSize; ^ lib/zstd/decompress/zstd_decompress.c:1751:28: note: Variable 'zds->inPos' is reassigned a value before the old one has been used. zds->inPos = 0; /* input is consumed */ ^ >> lib/zstd/common/zstd_deps.h:131:0: warning: syntax error [syntaxError] ^ >> lib/zstd/compress/zstd_compress.c:84:32: warning: Boolean result is used in >> bitwise operation. Clarify expression with parentheses. [clarifyCondition] if (!customMem.customAlloc ^ !customMem.customFree) return NULL; ^ lib/zstd/compress/zstd_compress.c:200:32: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] if (!customMem.customAlloc ^ !customMem.customFree) return NULL; ^ lib/zstd/compress/zstd_compress.c:3345:32: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] if (!customMem.customAlloc ^ !customMem.customFree) return NULL; ^ >> lib/zstd/common/zstd_internal.h:401:27: warning: Array 'DeBruijnClz[32]' >> accessed at index 509099, which is out of bounds. [arrayIndexOutOfBounds] return DeBruijnClz[(v * 0x07C4ACDDU) >> 27]; ^ lib/zstd/compress/zstd_compress.c:3494:40: note: Assignment 'limitedSrcSize=(uint32_t)(pledgedSrcSize<524288U?pledgedSrcSize:524288U)', assigned value is 524288 U32 const limitedSrcSize = (U32)MIN(pledgedSrcSize, 1U << 19); ^ lib/zstd/compress/zstd_compress.c:3495:90: note: Calling function 'ZSTD_highbit32', 1st argument 'limitedSrcSize-1' value is 524287 U32 const limitedSrcLog = limitedSrcSize > 1 ? ZSTD_highbit32(limitedSrcSize - 1) + 1 : 1; ^ lib/zstd/common/zstd_internal.h:395:17: note: Assignment 'v=val', assigned value is 524287 U32 v = val; ^ lib/zstd/common/zstd_internal.h:396:0: note: Assignment 'v=v|(v>>1)', assigned value is 524287 v |= v >> 1; ^ lib/zstd/common/zstd_internal.h:397:0: note: Assignment 'v=v|(v>>2)', assigned value is 524287 v |= v >> 2; ^ lib/zstd/common/zstd_internal.h:398:0: note: Assignment 'v=v|(v>>4)', assigned value is 524287 v |= v >> 4; ^ lib/zstd/common/zstd_internal.h:399:0: note: Assignment 'v=v|(v>>8)', assigned value is 524287 v |= v >> 8; ^ lib/zstd/common/zstd_internal.h:400:0: note: Assignment 'v=v|(v>>16)', assigned value is 524287 v |= v >> 16; ^ lib/zstd/common/zstd_internal.h:401:27: note: Array index out of bounds return DeBruijnClz[(v * 0x07C4ACDDU) >> 27]; ^ >> lib/zstd/common/zstd_deps.h:131:0: warning: syntax error [syntaxError] ^ >> lib/zstd/compress/zstd_lazy.c:663:74: warning: Overflow in pointer >> arithmetic, NULL pointer is subtracted. [nullPointerArithmetic] const U32 dictAndPrefixLength = (U32)((ip - prefixLowest) + (dictEnd - dictLowest)); ^ lib/zstd/compress/zstd_lazy.c:658:70: note: Assignment 'dictEnd=dictMode==ZSTD_dictMatchState?dms->window.nextSrc:NULL', assigned value is 0 const BYTE* const dictEnd = dictMode == ZSTD_dictMatchState ? ^ lib/zstd/compress/zstd_lazy.c:663:74: note: Null pointer subtraction const U32 dictAndPrefixLength = (U32)((ip - prefixLowest) + (dictEnd - dictLowest)); ^ >> lib/zstd/common/zstd_deps.h:131:0: warning: syntax error [syntaxError] ^ >> lib/zstd/compress/zstd_double_fast.c:97:75: warning: Overflow in pointer >> arithmetic, NULL pointer is subtracted. [nullPointerArithmetic] const U32 dictAndPrefixLength = (U32)((ip - prefixLowest) + (dictEnd - dictStart)); ^ lib/zstd/compress/zstd_double_fast.c:88:70: note: Assignment 'dictEnd=dictMode==ZSTD_dictMatchState?dms->window.nextSrc:NULL', assigned value is 0 const BYTE* const dictEnd = dictMode == ZSTD_dictMatchState ? ^ lib/zstd/compress/zstd_double_fast.c:97:75: note: Null pointer subtraction const U32 dictAndPrefixLength = (U32)((ip - prefixLowest) + (dictEnd - dictStart)); ^ >> lib/zstd/common/zstd_deps.h:131:0: warning: syntax error [syntaxError] ^ # https://github.com/0day-ci/linux/commit/400786d3b08436113bcb3c9c16a97eefc31317c1 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Nick-Terrell/Update-to-zstd-1-4-6/20200924-064102 git checkout 400786d3b08436113bcb3c9c16a97eefc31317c1 vim +179 lib/zstd/common/mem.h 173 174 175 MEM_STATIC U32 MEM_swap32(U32 in) 176 { 177 #if (defined (__GNUC__) && (__GNUC__ * 100 + __GNUC_MINOR__ >= 403)) \ 178 || (defined(__clang__) && __has_builtin(__builtin_bswap32)) > 179 return __builtin_bswap32(in); 180 #else 181 return ((in << 24) & 0xff000000 ) | 182 ((in << 8) & 0x00ff0000 ) | 183 ((in >> 8) & 0x0000ff00 ) | 184 ((in >> 24) & 0x000000ff ); 185 #endif 186 } 187 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
